Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vi character search parsing #483

Merged
merged 3 commits into from
Sep 18, 2022

Conversation

sholderbach
Copy link
Member

@sholderbach sholderbach commented Sep 18, 2022

Fixes #473

The parser has to consume the items from the iterator to be in a consistent state!
The specific issue with . #449 still remains open after this change.

Cleanup:

  • Move ViToTill logically to motion.rs

Fixes nushell#473

The parser has to consume the items from the iterator to be in a
consistent state!
@sholderbach sholderbach added the A-ViKeybinding Area: Vi(m) keybinding support label Sep 18, 2022
@sholderbach sholderbach merged commit 1bf9ad6 into nushell:main Sep 18, 2022
@sholderbach sholderbach deleted the fix-vi-charsearch branch September 18, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ViKeybinding Area: Vi(m) keybinding support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

f/F/t/T motions don't work for characters such as b or 0
1 participant