Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set MSRV to 1.62.1 #554

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Set MSRV to 1.62.1 #554

merged 2 commits into from
Mar 17, 2023

Conversation

jaudiger
Copy link
Contributor

I validated it with the cli cargo msrv:

cargo msrv
  [Meta]   cargo-msrv 0.16.0-beta.8 (a1b5066)                                                                                                                                                                                                                                                                       
Compatibility Check #1: Rust 1.62.1
  [OK]     Is compatible 

Compatibility Check #2: Rust 1.59.0                                                                                                                                                                                                                                                                                   [FAIL]   Is incompatible 
                                                                                                            
  ╭────────────────────────────────────────────────────────────────────────────────────────────────────────╮
  │     Updating crates.io index                                                                           │
  │ error: failed to select a version for the requirement `rstest = "^0.16.0"`                             │
  │ candidate versions found which didn't match: 0.13.0, 0.12.0, 0.11.0, ...                               │
  │ location searched: crates.io index                                                                     │
  │ required by package `reedline v0.17.0 (/home/jaudiger/Development/git-repositories/jaudiger/reedline)` │
  │                                                                                                        │
  ╰────────────────────────────────────────────────────────────────────────────────────────────────────────╯
                                                                                                            

Compatibility Check #3: Rust 1.60.0                                                                                                                                                                                                                                                                                   [FAIL]   Is incompatible 
                                                                                                                                                                                                                     
  ╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
  │ error: package `reedline v0.17.0 (/home/jaudiger/Development/git-repositories/jaudiger/reedline)` cannot be built because it requires rustc 1.62.1 or newer, while the currently active rustc version is 1.60.0 │
  │                                                                                                                                                                                                                 │
  ╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
                                                                                                                                                                                                                     

Compatibility Check #4: Rust 1.61.0                                                                                                                                                                                                                                                                                   [FAIL]   Is incompatible 
                                                                                                                                                                                                                     
  ╭─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
  │ error: package `reedline v0.17.0 (/home/jaudiger/Development/git-repositories/jaudiger/reedline)` cannot be built because it requires rustc 1.62.1 or newer, while the currently active rustc version is 1.61.0 │
  │                                                                                                                                                                                                                 │
  ╰─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
                                                                                                                                                                                                                     

Result:
   Considered (min … max):   Rust 1.56.0 … Rust 1.68.0 
   Search method:            bisect                    
   MSRV:                     1.62.1                    
   Target:                   x86_64-unknown-linux-gnu 

@sholderbach
Copy link
Member

Right as we pull in nu-ansi-term that should have increased.

@sholderbach sholderbach merged commit af7b447 into nushell:main Mar 17, 2023
@jaudiger jaudiger deleted the set_msrv branch May 17, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants