fix bracketed paste #577
fix bracketed paste #577
Conversation
|
Where is that transforms dialog in iterm2? |
|
It's auto popped up when I want to paste multiline content.. |
|
ok, i see it now. thanks |
|
Are we good here with the result of the PR so we can enable bracketed paste on the nushell side if desired? |
|
@sholderbach it works on my mac just fine. I'm not on windows today so I can't test it there. Not sure about linux. |
After this pr, I think we can enable bracketed paste on mac/Linux, but still not on windows, it depends on crossterm issue |
can't we check the platform and have a windows fix too? until crossterm decides to fix it? |
|
Sorry I don't have a work around for this on windows, see the comment: #576 (comment) It indicats that crossterm::Paste event doesn't work on windows. |
There was a problem hiding this comment.
at least on windows, it looks like it's pasting multi-line content fine. @sholderbach i'm fine with landing it.
Includes a fix for bracketed paste mode (#577)
This just includes the bracketed paste bugfix in nushell/reedline#577
# Description This just includes the bracketed paste bugfix in nushell/reedline#577 # User-Facing Changes None # Tests + Formatting # After Submitting
Fixes: #576
Actually the issue comes from iterm2 setting when I want to paste multiline script:
But yeah, when we enable bracketed paste, we can avoid pasted script to be executed automatically, I think it's safe to transfer from
\rto\n.Currently I'm not sure how windows handle bracketed feature, since it doesn't work with crossterm lib, I'm going to convert from "\r\n" to "\n" to make sure that everything is working properly