turn off default prompt styling (bold) to prevent leakage #615
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the bold attribute was hard coded and therefore leaked through. Example:
Before
Notice that the prompt is green bold even though I told it just green. Also, when i draw the prompt with the
do
command, it's drawn right. This is because thedo
command is rendering a buffer and the PROMPT_COMMAND is going through this code in reedline and hard-coding bold everywhere.After
Notice that when i tell it green, the prompt is drawn in green and with the
do
command. When I tell it green_bold the prompt is drawn in green_bold as well as with thedo
command.This is meant to close nushell/nushell#9123 when it's implemented in nushell.