Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't allow certain examples to compile without their features #658

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

fdncred
Copy link
Collaborator

@fdncred fdncred commented Nov 5, 2023

This PR forces examples that need certain features to nag about needing those features and not compile without specifying them.

image

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #658 (a3441ec) into main (60b3b62) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #658   +/-   ##
=======================================
  Coverage   49.21%   49.21%           
=======================================
  Files          43       43           
  Lines        7914     7914           
=======================================
  Hits         3895     3895           
  Misses       4019     4019           

@amtoine
Copy link
Member

amtoine commented Nov 5, 2023

that's pretty cool 😋

@fdncred fdncred merged commit 7ca3c38 into nushell:main Nov 5, 2023
8 checks passed
@fdncred fdncred deleted the examples_require_features branch November 5, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants