Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to build HistoryItemId values from the outside #677

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

ClementNerma
Copy link
Contributor

This PR allows to restore HistoryItemId values (and so HistoryItem as well) from e.g. a custom serialized history.
Required to implement a custom History.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #677 (349de6c) into main (37714c9) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #677   +/-   ##
=======================================
  Coverage   49.16%   49.16%           
=======================================
  Files          46       46           
  Lines        7926     7926           
=======================================
  Hits         3897     3897           
  Misses       4029     4029           
Files Coverage Δ
src/history/item.rs 44.89% <100.00%> (ø)

@ClementNerma
Copy link
Contributor Author

CI is now green.

@fdncred fdncred merged commit ca2f6c8 into nushell:main Dec 6, 2023
8 checks passed
@fdncred
Copy link
Collaborator

fdncred commented Dec 6, 2023

thanks

@sholderbach sholderbach mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants