Try fix prompt_start_row reset to 0 when opening a file without newline in Nushell #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e61be57.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #697 +/- ##
=======================================
Coverage 49.32% 49.32%
=======================================
Files 46 46
Lines 7988 7988
=======================================
Hits 3940 3940
Misses 4048 4048
|
|
after talking to @WindSoilder, let's give this a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is going to apply one of solution that @nibon7 attempted: nushell/nushell#11399 (comment)
Relative: nushell/nushell#11399