Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed text style #730

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Typed text style #730

merged 3 commits into from
Jan 29, 2024

Conversation

maxomatic458
Copy link
Contributor

closes #724

Adds selected_match_style and match_style to MenuTextStyle.

IdeMenu
grafik

ColumnarMenu
grafik

@maxomatic458
Copy link
Contributor Author

ill do some more testing to make sure it doesnt mess with #691

then i'll mark this PR as ready

@maxomatic458 maxomatic458 marked this pull request as ready for review January 28, 2024 20:35
@stormasm
Copy link
Contributor

@maxomatic458 thanks I tested this out and it looks good 👍

@stormasm stormasm merged commit 34af84e into nushell:main Jan 29, 2024
6 checks passed
@maxomatic458 maxomatic458 deleted the typed-text-style branch January 29, 2024 06:10
@fdncred
Copy link
Collaborator

fdncred commented Jan 29, 2024

How do we get this enabled in nushell? Is there a PR already that I'm missing?

@maxomatic458
Copy link
Contributor Author

@fdncred im making one right now, but i forgot to add the needed builder functions #731. <- once this is merged ill open the PR on nushell

@maxomatic458
Copy link
Contributor Author

@fdncred i just opened a PR on nushell nushell/nushell#11670

fdncred pushed a commit to nushell/nushell that referenced this pull request Jan 29, 2024
the match-text style (nushell/reedline#730) is
now configurable via the config.nu file.
the option ``correct_cursor_pos`` can now also be set in the config.nu
file.
dmatos2012 pushed a commit to dmatos2012/nushell that referenced this pull request Feb 20, 2024
the match-text style (nushell/reedline#730) is
now configurable via the config.nu file.
the option ``correct_cursor_pos`` can now also be set in the config.nu
file.
@sholderbach sholderbach mentioned this pull request May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "typed-text-style" to MenuTextStyle
3 participants