fix: set config_path in Containerd config #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/fix-set-config_path
branch
from
ccc532f
to
c8ba1cf
Compare
jimmidyson
force-pushed
the
dkoshkin/fix-set-config_path
branch
from
c8ba1cf
to
590f7b2
Compare
|
I'm confused why |
|
I just tested it in with Docker provider and didn't see any problem with this? |
jimmidyson
approved these changes
Feb 15, 2024
Merged
dkoshkin
pushed a commit
that referenced
this pull request
Feb 15, 2024
🤖 I have created a release *beep* *boop* --- ## 0.4.2 (2024-02-15) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Fixes 🔧 * fix: remove word konvoy/ and use cre/ by @dkoshkin in #365 * fix: v2/ in Containerd mirror path by @dkoshkin in #363 * fix: set config_path in Containerd config by @dkoshkin in #364 * fix: generate config with only globalImageRegistryMirror set by @dkoshkin in #362 ### Other Changes * refactor: Fix formatting issue by @jimmidyson in #368 * build: Include CAPX APis by @jimmidyson in #367 * build: Upgrade golangci-lint to 1.56.1 by @jimmidyson in #369 * docs: Update examples to be clusterctl templates by @jimmidyson in #361 **Full Changelog**: v0.4.1...v0.4.2 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
config_pathin the Containerd config as described in https://github.com/containerd/containerd/blob/main/docs/hosts.md#criThis is not enough, we also need to remove:registry.mirrorsfrom the config file, opening in case @jimmidyson you have some ideas on how we can do this, TOML doesn't have a nil valueNo additional changes are needed, the unnecessary mirror configuration will be removed from the OS image instead.