Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] fail to decompile UEFI boot_type in command calm decompile bp #289

Closed
ntnx-dlane opened this issue Feb 20, 2024 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@ntnx-dlane
Copy link

Describe the bug
When decompiling a blueprint that has UEFI and Secure boot enabled, calm-dsl 3.7.2.1, does not show that boot_type field as UEFI.

Branch/Container
master

To Reproduce
create a BP with UEFI and secure boot. Use Calm DSL to decompile said blueprint. Review blueprint.py file and observe no settings for UEFI.

Expected behavior
boot_type needs to be observed as part of the decompile.

Findings/Troubleshooting Done
Confirmed with multiple blueprints, and multiple users.

Available Logs/Data
n/a

Screenshots
n/a

** System Configuration:**

  • OS: mac 14.2.x
  • Python: 3.11.2

Additional context
n/a

@ntnx-dlane ntnx-dlane added the bug Something isn't working label Feb 20, 2024
dwivediprab pushed a commit that referenced this issue Mar 15, 2024
The secret variable strip was not happening before the upload API.
Made changes to support it.

(cherry picked from commit 349d81d472aade82fb92f676745878c93921ba3c)
@dwivediprab
Copy link
Contributor

PR: https://github.com/ideadevice/calm-dsl/pull/390
(Added decompilation for boot_type)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants