Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue 285 cloudinit v2 #292

Conversation

yannickstruyf3
Copy link
Collaborator

fix #285

@yannickstruyf3 yannickstruyf3 force-pushed the bugfix/issue-285-cloudinit_v2 branch 2 times, most recently from 2291c68 to 585d6b3 Compare September 8, 2021 20:33
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good but it has some logging line for debugging purposes but not sure if it's needed or not

nutanix/structure.go Outdated Show resolved Hide resolved
nutanix/structure.go Outdated Show resolved Hide resolved
nutanix/structure.go Outdated Show resolved Hide resolved
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the tests pass

@siddharth-nutanix siddharth-nutanix merged commit f29ce89 into nutanix:1.2.2-dev Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants