-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/issue 285 cloudinit v2 #292
Merged
siddharth-nutanix
merged 5 commits into
nutanix:1.2.2-dev
from
yannickstruyf3:bugfix/issue-285-cloudinit_v2
Oct 29, 2021
Merged
Bugfix/issue 285 cloudinit v2 #292
siddharth-nutanix
merged 5 commits into
nutanix:1.2.2-dev
from
yannickstruyf3:bugfix/issue-285-cloudinit_v2
Oct 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannickstruyf3
force-pushed
the
bugfix/issue-285-cloudinit_v2
branch
2 times, most recently
from
September 8, 2021 20:33
2291c68
to
585d6b3
Compare
coderGo93
reviewed
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good but it has some logging line for debugging purposes but not sure if it's needed or not
coderGo93
reviewed
Sep 8, 2021
coderGo93
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if the tests pass
yannickstruyf3
force-pushed
the
bugfix/issue-285-cloudinit_v2
branch
from
September 10, 2021 12:20
f8a7ae2
to
bd08a24
Compare
yannickstruyf3
force-pushed
the
bugfix/issue-285-cloudinit_v2
branch
from
September 10, 2021 12:40
bd08a24
to
1f29f93
Compare
yannickstruyf3
force-pushed
the
bugfix/issue-285-cloudinit_v2
branch
from
September 10, 2021 12:52
1f29f93
to
ceec534
Compare
marinsalinas
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #285