Add support for linking service and address groups to network security rules

[jan-walther]

Expansion of #322 to support linking the newly created resourced with a network security rule

[siddharth-nutanix]

Hi @jan-walther ,
Can you pull nutanix master?

[jan-walther]

Done :)

[siddharth-nutanix]

/ok-to-test

[siddharth-nutanix]

Hi @jan-walther
I see that we are passing service group property in security rules resource type.
Can you also add datasource for service group (both singular and plural) ?

[jan-walther]

Hi @siddharth-nutanix,
yes but my time atm is very limited and data sources aren't strictly necessary for my purposes :/

[Chup4Chups]

Hi guys,
I tested the PR locally and it worked almost fine.
However, I had to make small changes to be able to create a network security rule with address_groups and service_groups

1. field "ip_subnet" is assigned an empty struct by default which lead to an error from the APIv3.
   I just moved the assignment elsewhere where struct is not empty, but there is probably a better solution.

2. need to put fields uuid / kind as Required to match APIv3 for address_groups and service_groups

$ git diff
diff --git a/nutanix/resource_nutanix_network_security_rule.go b/nutanix/resource_nutanix_network_security_rule.go
index e990310d..26743471 100644
--- a/nutanix/resource_nutanix_network_security_rule.go
+++ b/nutanix/resource_nutanix_network_security_rule.go
@@ -1153,6 +1153,7 @@ func expandNetworkRule(prefix string, d *schema.ResourceData) *v3.NetworkSecurit
                        if ippl, ipok := nr["ip_subnet_prefix_length"]; ipok && ippl.(string) != "" {
                                if i, err := strconv.Atoi(ippl.(string)); err == nil {
                                        iPSubnet.PrefixLength = utils.Int64Ptr(int64(i))
+                                       nrItem.IPSubnet = iPSubnet
                                }
                        }

@@ -1220,8 +1221,6 @@ func expandNetworkRule(prefix string, d *schema.ResourceData) *v3.NetworkSecurit
                        if icmp, icmpok := nr["icmp_type_code_list"]; icmpok {
                                nrItem.IcmpTypeCodeList = expandIcmpTypeCodeList(icmp)
                        }
-
-                       nrItem.IPSubnet = iPSubnet
                        if !reflect.DeepEqual(*filter, v3.CategoryFilter{}) {
                                nrItem.Filter = filter
                        }
@@ -1560,11 +1559,11 @@ func referenceListSchema() *schema.Schema {
                        Schema: map[string]*schema.Schema{
                                "kind": {
                                        Type:     schema.TypeString,
-                                       Computed: true,
+                                       Required: true,
                                },
                                "uuid": {
                                        Type:     schema.TypeString,
-                                       Computed: true,
+                                       Required: true,
                                },
                                "name": {
                                        Type:     schema.TypeString,

[siddharth-nutanix]

/ok-to-test

Acceptance test run status: success
Line code coverage is 59.4

[siddharth-nutanix]

Shouldn't UUID be marked as optional & computed as it will be an input to API.

@jan-walther thoughts?

Can you also attach a working example in the PR?