Optimize Image upload to avoid buffering. Add cluster related fields in image upload resource & data source for PC #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhati-pradeep
changed the title
WWhitt
reviewed
Apr 27, 2022
|
|
||
| // Set req.ContentLength and req.GetBody as internally there is no implementation of such for os.File type reader | ||
| // http.NewRequest() only sets this values for types - bytes.Buffer, bytes.Reader and strings.Reader | ||
| // Refer https://github.com/golang/go/blob/a0f77e56b7a7ecb92dca3e2afdd56ee773c2cb07/src/net/http/request.go#L896 |
There was a problem hiding this comment.
Nit: While this is true for those data types, it doesn't seem necessary when using an *os.File, see my example in the issue -- it uploaded perfectly fine without pre-emptively specifying content-length. That being said, I totally support not relying on default behavior here.
Edit: while I did get uploads without doing that, it wasn't working how I thought. ignore me. I agreed with explicitly setting it anyway
bhatipradeep
changed the title
siddharth-kulshrestha
approved these changes
Apr 29, 2022
|
/ok-to-test
|
|
Testcase failed due to setup config mismatch. Passing locally after fixing. Merging it to master. Attached the screenshot.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New additions: