Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impr/1.6 network testcases #470

Merged
merged 29 commits into from
Jul 6, 2022
Merged

Impr/1.6 network testcases #470

merged 29 commits into from
Jul 6, 2022

Conversation

Abhishekism9450
Copy link
Contributor

Added tcs for -

  1. PBRs
  2. Floating IPs
  3. Static Routes

Added datasource for pbrs .

@abhimutant
Copy link
Collaborator

abhimutant commented Jun 27, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (43.8) is below threshold (50). Kindly add more acceptance tests.

1 similar comment
@abhimutant
Copy link
Collaborator

abhimutant commented Jun 28, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (43.8) is below threshold (50). Kindly add more acceptance tests.

@Abhishekism9450
Copy link
Contributor Author

/ok-to-test pc

@abhimutant
Copy link
Collaborator

abhimutant commented Jun 29, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (43.8) is below threshold (50). Kindly add more acceptance tests.

@bhati-pradeep
Copy link
Collaborator

Also please add fields for local static routes and default static routes in data source.
Add default routes in resource as well.

@bhati-pradeep
Copy link
Collaborator

Add fields for all kind of static routes in data source

@abhimutant
Copy link
Collaborator

abhimutant commented Jun 30, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (41.9) is below threshold (50). Kindly add more acceptance tests.

@abhimutant
Copy link
Collaborator

abhimutant commented Jul 1, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (42.5) is below threshold (50). Kindly add more acceptance tests.

@abhimutant
Copy link
Collaborator

abhimutant commented Jul 1, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (43.7) is below threshold (50). Kindly add more acceptance tests.

@abhimutant
Copy link
Collaborator

abhimutant commented Jul 4, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (43.9) is below threshold (50). Kindly add more acceptance tests.

@abhimutant
Copy link
Collaborator

abhimutant commented Jul 5, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (43.9) is below threshold (50). Kindly add more acceptance tests.

@abhimutant
Copy link
Collaborator

abhimutant commented Jul 5, 2022 •
edited by github-actions bot
Loading

/ok-to-test pc

Acceptance test run status: failure
Current line coverage (43.6) is below threshold (50). Kindly add more acceptance tests.

@abhimutant abhimutant merged commit 0655e51 into nutanix:feat/1.6.0 Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhati-pradeep bhati-pradeep bhati-pradeep left review comments

@siddharth-kulshrestha siddharth-kulshrestha siddharth-kulshrestha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abhishekism9450 @abhimutant @bhati-pradeep @siddharth-kulshrestha