Fix Secure boot VMs when doing updates #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle SECURE_BOOT VMs when updating (terraform apply)
abhimutant
reviewed
Aug 25, 2023
| @@ -1203,6 +1203,12 @@ func resourceNutanixVirtualMachineUpdate(ctx context.Context, d *schema.Resource | |||
| metadata.SpecVersion = specVersion | |||
| } | |||
|
|
|||
| // Check if we are dealing with SECURE_BOOT machine, MachineType is needed then set to Q35 | |||
There was a problem hiding this comment.
we don't need this check at two places. we can always preFill the machineType using the response.
here:
|
Closing as fix is already merged in master. #633 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my simple fix for SECURE_BOOT VMs to handle terraform apply updates, when it's doing first power off VM and then powering it back on.
I noticed that MachineType was not set to Q35 when powering off was done and second time MachineType is missing when actual update is done and VM is booted after that.
Issue #494