Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize BootConfig struct before the child attributes #53

Merged
merged 3 commits into from
Oct 26, 2020
Merged

Initialize BootConfig struct before the child attributes #53

merged 3 commits into from
Oct 26, 2020

Conversation

marinsalinas
Copy link
Contributor

@marinsalinas marinsalinas commented Apr 25, 2019 •
edited
Loading

closes #28

  • Code Fixed
  • Added it to test case
  • Documentation is not required.

@ghost ghost added the size/XXL label Apr 25, 2019
@marinsalinas marinsalinas changed the title WIP: initialize BootConfig struct before the child attributes Initialize BootConfig struct before the child attributes Oct 21, 2020
coderGo93
coderGo93 approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@coderGo93 coderGo93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the testacc has passed then LGTM

@marinsalinas
Copy link
Contributor Author

All the tests passed, merge it now!

@marinsalinas marinsalinas merged commit 9343673 into master Oct 26, 2020
@marinsalinas marinsalinas deleted the boot-device-order-list-#28 branch October 26, 2020 21:03
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
@crizstian
Merge pull request nutanix#53 from nutanix/develop
eaeb4c6 
Develop
yannickstruyf3 pushed a commit to yannickstruyf3/terraform-provider-nutanix that referenced this pull request Nov 9, 2021
@marinsalinas
Merge pull request nutanix#53 from nutanix/boot-device-order-list-#28
1f96ac6 
Initialize BootConfig struct before the child attributes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderGo93 coderGo93 coderGo93 approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform crashes when trying to specify boot_device_order_list for a vm resource
2 participants
@marinsalinas @coderGo93