-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added import and snapshot name to Optional #561
Merged
abhimutant
merged 14 commits into
nutanix:feat/1.8.1
from
Abhishekism9450:imprv/ndb-imports
Apr 18, 2023
Merged
added import and snapshot name to Optional #561
abhimutant
merged 14 commits into
nutanix:feat/1.8.1
from
Abhishekism9450:imprv/ndb-imports
Apr 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth-kulshrestha
approved these changes
Mar 1, 2023
Abhishekism9450
force-pushed
the
imprv/ndb-imports
branch
from
March 23, 2023 12:01
a717204
to
f3c1f22
Compare
siddharth-kulshrestha
approved these changes
Apr 17, 2023
bhati-pradeep
requested changes
Apr 17, 2023
bhati-pradeep
approved these changes
Apr 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…led in networks datasource
Abhishekism9450
force-pushed
the
imprv/ndb-imports
branch
from
April 18, 2023 06:37
6d94ec9
to
55e0899
Compare
abhimutant
approved these changes
Apr 18, 2023
This was referenced Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports for restore, scale, tags, cluster, maintenance window, profile, slas.
Snapshot resource : name is set to Optional with default.
d.id is being checked for nil in readContext.