Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: compare bootconfig against previous value #641

Merged
merged 6 commits into from
Oct 25, 2023
Merged

fix: compare bootconfig against previous value #641

merged 6 commits into from
Oct 25, 2023

Conversation

fad3t
Copy link
Contributor

@fad3t fad3t commented Oct 12, 2023

fixes #640

@abhimutant abhimutant changed the base branch from master to feat/1.9.4 October 25, 2023 05:07
@abhimutant
Copy link
Collaborator

LGTM

abhimutant
abhimutant approved these changes Oct 25, 2023
View reviewed changes
nutanix/resource_nutanix_virtual_machine.go Outdated Show resolved Hide resolved
bhati-pradeep
bhati-pradeep approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@bhati-pradeep bhati-pradeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhimutant abhimutant merged commit 77c4f42 into nutanix:feat/1.9.4 Oct 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhimutant abhimutant abhimutant approved these changes

@bhati-pradeep bhati-pradeep bhati-pradeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VM rebooted at every change because of hotPlugChange set to false
3 participants
@fad3t @abhimutant @bhati-pradeep