Add validFrom and validUntil aliases for issuanceDate and expirationDate #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerardsn
force-pushed
the
feature/add-validFrom-validUntil
branch
from
406915e
to
60691c6
Compare
vc/vc.go
Outdated
Comment on lines
142
to
154
| // IssuanceDate is a rfc3339 formatted datetime. Has alias ValidFrom | ||
| IssuanceDate *time.Time `json:"issuanceDate,omitempty"` | ||
| // ValidFrom is a rfc3339 formatted datetime. It is optional, and is mutually exclusive with IssuanceDate (not enforced). | ||
| // It's a forwards compatible alternative for IssuanceDate. | ||
| // The jwt-vc 'nbf' field will unmarshal to IssuanceDate, which may not match with the JSON-LD definition of certain VCs. | ||
| ValidFrom *time.Time `json:"validFrom,omitempty"` | ||
| // ExpirationDate is a rfc3339 formatted datetime. Has alias ValidUntil. It is optional | ||
| ExpirationDate *time.Time `json:"expirationDate,omitempty"` | ||
| // ValidFrom is a rfc3339 formatted datetime. It is optional, and is mutually exclusive with ExpirationDate (not enforced). | ||
| // It's a forwards compatible alternative for ExpirationDate. | ||
| // The jwt-vc 'exp' field will unmarshal to ExpirationDate, which may not match with the JSON-LD definition of certain VCs. | ||
| ValidUntil *time.Time `json:"validUntil,omitempty"` |
There was a problem hiding this comment.
Maybe add some info on which spec version desires which field
woutslakhorst
approved these changes
Dec 1, 2023
reinkrul
approved these changes
Dec 1, 2023
gerardsn
force-pushed
the
feature/add-validFrom-validUntil
branch
from
feec50c
to
b4e44e3
Compare
gerardsn
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for StatusList2021. These are already in the v1 vc context, and issuanceDate/expirationDate have been removed in v2. (v1 also mentions possible future addition of 'issued', but this does not exist in the v2 model so not added for now)