added tokenization and transformation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe you can talk me through this |
reinkrul
requested changes
Jun 14, 2021
| } else { | ||
| err = fn(cKey, entry) | ||
| // value/search terms transformation (eg lowercase) | ||
| tokens := indexParts[0].Tokenize(seek) |
There was a problem hiding this comment.
quite complex, could use some refactoring maybe?
There was a problem hiding this comment.
It does require a refactor, but this PR is not the time to do it. See #5
|
|
||
| if a, ok := val.([]interface{}); ok { | ||
| var ra []interface{} | ||
| for _, ai := range a { | ||
| interm := j.matchRecursive(parts, ai) | ||
| interm, err := j.matchRecursive(parts, ai) |
There was a problem hiding this comment.
all these 1 or 2 character variables makes it hard to understand the code (because I don't work on it), since I've got to really analyze it to guess/derive what is actually means
There was a problem hiding this comment.
part of the refactor.
reinkrul
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokenization happens first.
A whitespace tokenizer has been provided.
This allows for "care organization A" to be indexed with terms:
care,organizationanda.It's pluggable, so other transformers (like pronunciation) can be used.