Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test eOverdracht flow using Chromium browser #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test eOverdracht flow using Chromium browser #23

wants to merge 1 commit into from

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented May 5, 2022 •
edited
Loading

Waiting for nuts-foundation/nuts-demo-ehr#262

Tests eOverdracht flow;

  1. Set up vendor and care organizations
  2. Register patient
  3. Create transfer dossier and assign
  4. Log in as receiving organization, check inbox and assert transfer details

Future features:

  • Make screenshot when it fails
  • Run headless on GitHub part of the build

@reinkrul reinkrul marked this pull request as ready for review May 17, 2022 13:45
woutslakhorst
woutslakhorst reviewed May 17, 2022
View reviewed changes
browser-tests/browser/chrome.go
execCtx,
//chromedp.WithDebugf(log.Printf),
)
go func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the subContext is done, you have to cancel the parent? Shouldn't this context be the parent context for the others?

woutslakhorst
woutslakhorst requested changes May 17, 2022
View reviewed changes
browser-tests/run-test.sh
waitForDCService ehr
waitForDCService admin

go test -v .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing docker compose down

woutslakhorst
woutslakhorst requested changes May 17, 2022
View reviewed changes
Copy link
Member

@woutslakhorst woutslakhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be stuck on creating transfer: Create transfer button not pressed

@reinkrul reinkrul mentioned this pull request Apr 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst requested changes

@gerardsn gerardsn Awaiting requested review from gerardsn

@stevenvegt stevenvegt Awaiting requested review from stevenvegt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reinkrul @woutslakhorst