New 'timeseries' resource #897
Conversation
|
|
||
|
|
||
| (def collection-acl {:query ["group/nuvla-admin"] | ||
| :add ["group/nuvla-admin"]}) |
There was a problem hiding this comment.
Only admin can add and query a timeserie? Why not opening it to all authenticated users
| @@ -0,0 +1,145 @@ | |||
| (ns sixsq.nuvla.server.resources.timeseries | |||
There was a problem hiding this comment.
resource name is always singular
There was a problem hiding this comment.
I was thinking the same, but I was not sure and I google for it: https://www.merriam-webster.com/grammar/series-singular-plural-grammar-usage#:~:text=It%20is%20usually%20seen%20in,series%20is%20a%20zero%20plural.
Apparently 'series' is both singular and plural in english, there is no 'serie' :-)
| [request] | ||
| (let [{{:keys [resource-id]} :body :as response} (add-impl request)] | ||
| (create-timeseries resource-id) | ||
| response)) |
There was a problem hiding this comment.
missing storing the timeserie document as a doc inside nuvla-timeserie index
There was a problem hiding this comment.
I think it is done inside add-impl
|
|
||
| (defmethod crud/query resource-type | ||
| [request] | ||
| (query-impl request)) |
There was a problem hiding this comment.
query not working since docs are note stored
There was a problem hiding this comment.
I think it should work, but I need to add a test for it, there is only one for the retrieve.
alebellu
force-pushed
the
issue_tasklist_3059
branch
from
ddbfcfc
to
ce45107
Compare
…dling in ES binding
…dling in ES binding
…m is not yet created
alebellu
force-pushed
the
issue_tasklist_3059
branch
from
c357a67
to
e709f88
Compare
|
SonarQube Quality Gate
|
Closes SixSq/tasklist#3059