feat: Add cookie support for Pull mode jobs executed from NuvlaEdge #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schaubl
reviewed
Nov 5, 2024
| def _init_nuvla_api(self): | ||
| # true unless header authentication is used | ||
| reauthenticate = self.args.api_authn_header is None | ||
| cookies = os.getenv("JOB_COOKIES", "") | ||
| persist_cookie = cookies != "" and cookies is not None |
There was a problem hiding this comment.
could be simplified with
Suggested change
| persist_cookie = cookies != "" and cookies is not None | |
| persist_cookie = bool(cookies) |
schaubl
reviewed
Nov 5, 2024
There was a problem hiding this comment.
I would use a tmpfile for the cookie file.
But in fact, why writing the cookie to a file ?
After the Api instance is created it's possible to do:
self.api = Api(...)
self.api.session.cookies.set_cookie(cookie)In this case it needs to be a (single) cookie like returned by the Set-Cookie HTTP header.
But you can load a mozilla cookie file in memory with BytesIO (or StringIO):
self.api = Api(...)
self.api.session.cookies = MozillaCookieJar()
self.api.session.cookies._really_load(BytesIO(cookies), '', ignore_discard=True)
|
Please also see the review comment in the other PR: nuvlaedge/nuvlaedge#214 (review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes sixsq/tasklist#3225