Skip to content

Commit

Permalink
fix(Github workflow): Install lein missing in ubuntu 24 (#1657)
Browse files Browse the repository at this point in the history
* fix(Github workflow): Install lein missing in ubuntu 24

* fix(component test): Use playwright from docker instead of installing it

* fix(e2e test): Fix e2e depl group test
  • Loading branch information
0xbase12 authored Oct 14, 2024
1 parent 6d4acd8 commit cbaa17c
Show file tree
Hide file tree
Showing 7 changed files with 42 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ jobs:
distribution: 'temurin'
java-version: '21'

- name: Install clojure tools
uses: DeLaGuardo/[email protected]
with:
lein: 2.11.2

- name: Project version
working-directory: code
shell: bash
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/bundle_size.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,10 @@ jobs:
node-version: 16
- name: Install dependencies
run: npm ci --legacy-peer-deps
- name: Install clojure tools
uses: DeLaGuardo/[email protected]
with:
lein: 2.11.2
- name: Analyze bundle size
run: npx shadow-cljs run shadow.cljs.build-report nuvla-ui bundle-size-report-${{ github.sha }}.html
- uses: actions/upload-artifact@v3
Expand Down
17 changes: 15 additions & 2 deletions .github/workflows/component_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,12 @@ jobs:
component-test:
timeout-minutes: 60
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.42.1-jammy
env:
TZ: Europe/Zurich
env:
HOME: /root
steps:
- uses: actions/checkout@v4
- name: Cache node modules
Expand Down Expand Up @@ -46,8 +52,15 @@ jobs:
node-version: '18.x'
- name: Install dependencies
run: npm install
- name: Install Playwright
run: npx playwright install --with-deps
- name: Set up JDK 21
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '21'
- name: Install clojure tools
uses: DeLaGuardo/[email protected]
with:
lein: 2.11.2
- name: Build Portfolio
run: lein build-portfolio
- name: Serve Portfolio and run tests
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ jobs:
with:
# Disabling shallow clone is recommended for improving relevancy of reporting for sonar
fetch-depth: 0
- name: Install clojure tools
uses: DeLaGuardo/[email protected]
with:
lein: 2.11.2
- name: Extract branch name and substitute slashes
shell: bash
working-directory: code
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/e2e_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,15 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Set up JDK 21
uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '21'
- name: Install clojure tools
uses: DeLaGuardo/[email protected]
with:
lein: 2.11.2
- name: Install dependencies
run: npm ci --legacy-peer-deps
- name: Await CF Pages
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 16
- name: Install clojure tools
uses: DeLaGuardo/[email protected]
with:
lein: 2.11.2
- name: Install dependencies
run: npm ci --legacy-peer-deps
- name: Run unit tests
Expand Down
2 changes: 1 addition & 1 deletion code/test/e2e/loggedin/depl-groups.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ test('test', async ({ page }, { config }) => {

await page.locator('.nuvla-apps button.add-button').first().click();

await page.getByRole('link', { name: 'BlackBox This app allows users to trigger the creation of an airplane… Project: sixsq Vendor: Vendorgroup/sixsq-vendor Price: free trial and then EUR 0.33/day blackbox ready Add to selection' }).click();
await page.getByRole('link', { name: 'BlackBox This app allows' }).getByLabel('Add to selection').click();

await expect(page).toHaveURL(new RegExp(`${baseURL}/ui/deployment-groups/create`));

Expand Down

0 comments on commit cbaa17c

Please sign in to comment.