Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back resetOnError #197

Merged
merged 1 commit into from
Jun 2, 2018
Merged

Bring back resetOnError #197

merged 1 commit into from
Jun 2, 2018

Conversation

ishitatsuyuki
Copy link
Contributor

Blame: @pi0 c38a1e4

pi0
pi0 requested changes May 30, 2018
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was intentialy removed as we need more customization ability. BTW If you think would be a good idea we can bring it back. My suggestion is to make it more customizable by allowing to reset on only certain axios error codes...

@ishitatsuyuki
Copy link
Contributor Author

@pi0 I have added what you said. This hasn't been tested yet.

@ishitatsuyuki
Copy link
Contributor Author

@pi0 Do you have any questions or concerns?

@pi0 pi0 merged commit 469f2f8 into nuxt-community:dev Jun 2, 2018
@pi0
Copy link
Member

pi0 commented Jun 2, 2018

Thanks

@pi0 pi0 mentioned this pull request May 23, 2019
Merged
@pi0
Copy link
Member

pi0 commented May 30, 2019

This PR has been published in v4.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishitatsuyuki @pi0