Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracing): initialize server side tracing correctly #517

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Mar 7, 2023

The @sentry/tracing package has to be imported so that some tracing extensions are added.
Also forgot to pass tracing option on the server so tracing was never enabled there.

Fixes #508

@rchl rchl mentioned this pull request Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #517 (f51d73b) into main (5472233) will decrease coverage by 1.70%.
The diff coverage is n/a.

❗ Current head f51d73b differs from pull request most recent head b948aed. Consider uploading reports for the commit b948aed to get more accurate results

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   72.88%   71.18%   -1.70%     
==========================================
  Files           1        1              
  Lines          59       59              
  Branches       24       24              
==========================================
- Hits           43       42       -1     
- Misses         13       14       +1     
  Partials        3        3              
Impacted Files Coverage Δ
lib/module.js 71.18% <0.00%> (-1.70%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@rchl rchl merged commit c7eda63 into main Mar 7, 2023
@rchl rchl deleted the fix/server-tracing branch March 7, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSR tracing won't working
1 participant