Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add is external logic from NuxtLink component #2273

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

TitusKirch
Copy link
Contributor

@TitusKirch TitusKirch commented Jul 29, 2023

πŸ”— Linked issue

#2272

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #2272

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Collaborator

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
Look good to me.

@BobbieGoede
Could you review this PR, please? πŸ™

@kazupon kazupon requested a review from BobbieGoede July 30, 2023 05:18
Copy link
Collaborator

@BobbieGoede BobbieGoede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! My review feels a bit nitpicky, your PR gets my approval either way πŸ˜„

src/runtime/components/NuxtLinkLocale.ts Outdated Show resolved Hide resolved
src/runtime/components/NuxtLinkLocale.ts Outdated Show resolved Hide resolved
@BobbieGoede BobbieGoede merged commit d8889ce into nuxt-modules:next Aug 1, 2023
5 checks passed
@BobbieGoede
Copy link
Collaborator

Thanks again for contributing! πŸš€β€οΈ

DarthGigi pushed a commit to DarthGigi/i18n that referenced this pull request Apr 16, 2024
* Add is external logic from NuxtLink component

* Add test

* Linting

* Use NuxtLinkLocale for external links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuxtLinkLocale behaves differently than NuxtLink for external links
3 participants