fix(module): correct runtime nuxt hook module path #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2023
DarthGigi
pushed a commit
to DarthGigi/i18n
that referenced
this pull request
Apr 16, 2024
* fix(module): correct runtime nuxt hook module path * chore(typescript): add `#app` subdirectory paths to configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
n/a
❓ Type of change
📚 Description
Hooks like
i18n:localeSwitchedas used in https://v8.i18n.nuxtjs.org/guide/runtime-hooks#usage lead to a linter error for me when used together with @harlan-zw'snuxt-seo-kit-moduleunless I make the module declaration path more specific as done in this PR. Could the reason be that Harlan's declaration is more specific and shadows the currently used declaration somehow?See for context: https://github.com/harlan-zw/nuxt-seo-experiments/blob/c6ae207dd1aac9c519f26dff8ce1713cce1048b9/src/templates.ts#L19
I'll setup a minimal reproduction if necessary ❤️
📝 Checklist