fix: redirect from 404 to defaultLocale if there is matching route #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the `setLocale` logic to, in case current route is 404, to try to find a matching one for current locale. This is for situations when using `prefix` strategy where the root (`/`) route doesn't exist. We will try to find and redirect to prefixed route matching resolved locale. Also worked around Nuxt issue (nuxt/nuxt#4491 ) with `redirect` not working when called from a plugin in SPA mode. Required for the above fix above to be functional in SPA. Resolves #677 Resolves #491
Codecov Report
@@ Coverage Diff @@
## master #685 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 3 3
Lines 120 120
Branches 33 33
=======================================
Hits 119 119
Misses 1 1 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: redirect from 404 to defaultLocale if there is matching route
Changes the
setLocalelogic to, in case current route is 404, totry to find a matching one for current locale. This is for situations
when using
prefixstrategy where the root (/) route doesn't exist.We will try to find and redirect to prefixed route matching resolved locale.
Also worked around Nuxt issue (nuxt/nuxt#4491 )
with
redirectnot working when called from a plugin in SPA mode.Required for the above fix above to be functional in SPA.
Resolves #677
Resolves #491