Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't leave out non-prefixed routes for generate + prefix strategy #726

Merged
merged 1 commit into from
May 22, 2020

Conversation

rchl
Copy link
Collaborator

@rchl rchl commented May 22, 2020

To avoid having to create server-side redirect rules, the non-prefixed
routes are not removed when using prefix strategy with Nuxt generate.
The non-prefixed routes should automatically redirect to default locale
routes.

Resolves #700

To avoid having to create server-side redirect rules, the non-prefixed
routes are not removed when using prefix strategy with Nuxt generate.
The non-prefixed routes should automatically redirect to default locale
routes.

Resolves #700
@codecov
Copy link

codecov bot commented May 22, 2020

Codecov Report

Merging #726 into master will decrease coverage by 1.56%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   99.16%   97.60%   -1.57%     
==========================================
  Files           3        3              
  Lines         120      125       +5     
  Branches       33       34       +1     
==========================================
+ Hits          119      122       +3     
- Misses          1        3       +2     
Impacted Files Coverage Δ
src/helpers/routes.js 96.61% <50.00%> (-3.39%) ⬇️
src/index.js 97.82% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a853de9...286029f. Read the comment docs.

@rchl rchl merged commit 97fabbf into master May 22, 2020
@rchl rchl deleted the fix/non-prefix-routes-for-generate branch May 22, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant