fix: crash on using nuxt-i18n properties in a component with i18n options #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
force-pushed
the
fix/component-local-crash
branch
2 times, most recently
from
55b6abd
to
e1f44f4
Compare
…ions When component specifies some VueI18n options using a plain i18n object in component options, VueI18n creates a separate component-local instance of itself. That instance wasn't extend with nuxt-i18n-specific properties that root instance has. Fix by adding an API in vue-i18n for handling that and use here. Resolves #557
rchl
force-pushed
the
fix/component-local-crash
branch
from
e1f44f4
to
659f0aa
Compare
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 3 3
Lines 129 129
Branches 35 35
=======================================
Hits 126 126
Misses 3 3 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When component specifies some VueI18n options using a plain i18n object
in component options, VueI18n creates a separate component-local instance
of itself. That instance wasn't extended with nuxt-i18n-specific properties
that root instance has.
Fix by adding an API in vue-i18n for handling that and use it here.
Resolves #557