Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide storybook and essential addons as transitive dependency #782

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tobiasdiez
Copy link
Collaborator

@tobiasdiez tobiasdiez commented Sep 21, 2024

🔗 Linked issue

📚 Description

Provides storybook and @storybook/addon-essentials as nested dependencies of our storybook-addon. In this way, users don't have to install these packages themselves (and sync versions with our storybook version).

Copy link

netlify bot commented Sep 21, 2024

Deploy Preview for nuxt-storybook ready!

Name Link
🔨 Latest commit 5b1ced5
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-storybook/deploys/66f026e624d7f70008f31adf
😎 Deploy Preview https://deploy-preview-782--nuxt-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tobiasdiez
Copy link
Collaborator Author

Fails currently to import the addons. Not sure why, hopefully fixed by storybookjs/storybook#28798.

@tobiasdiez tobiasdiez added the status: blocked Blocked by an issue / missing feature of a dependency, or by another issue label Sep 22, 2024
@tobiasdiez tobiasdiez marked this pull request as draft September 22, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Blocked by an issue / missing feature of a dependency, or by another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant