Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first class hmr #818

Merged
merged 34 commits into from
Apr 12, 2024
Merged

feat: first class hmr #818

merged 34 commits into from
Apr 12, 2024

Conversation

ineshbose
Copy link
Collaborator

@ineshbose ineshbose commented Feb 28, 2024

previously worked on in #795, then reverted #817

Test on Stackblitz: https://stackblitz.com/github/nuxt-modules/tailwindcss/tree/first-class-hmr


closes #682 and closes #826

Copy link

nuxt-studio bot commented Feb 28, 2024

Live Preview ready!

Name Edit Preview Latest Commit
TailwindCSS Edit on Studio ↗︎ View Live Preview 2c0d664

src/config.ts Outdated Show resolved Hide resolved
@ineshbose
Copy link
Collaborator Author

Expose config templates may not change.. need to look into that

@ineshbose
Copy link
Collaborator Author

tailwindcss:resolvedConfig hook is broken now 🔪😃👍

@ineshbose
Copy link
Collaborator Author

need to consider using unctx or something now

src/context.ts Outdated Show resolved Hide resolved
src/module.ts Outdated Show resolved Hide resolved
src/context.ts Outdated Show resolved Hide resolved
src/context.ts Outdated Show resolved Hide resolved
Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for nuxt-tailwindcss ready!

Name Link
🔨 Latest commit 47f3be4
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-tailwindcss/deploys/661991c67f51e700082ee793
😎 Deploy Preview https://deploy-preview-818--nuxt-tailwindcss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ineshbose
Copy link
Collaborator Author

on fresh setup without prepare, some styling is flashing and I may not be too happy with how objects are copied while needing to be passed in configMerger (there's lot of complexity here as well..)

@ineshbose
Copy link
Collaborator Author

Just build now not detecting added templates...

@ineshbose
Copy link
Collaborator Author

I've been in half minds around writing tests.. may write them or release soon

@ineshbose ineshbose merged commit 81595fe into main Apr 12, 2024
6 checks passed
@ineshbose
Copy link
Collaborator Author

minor improvement if needed in future - do findPath within loadConfig and also listen for 'add' event from builder in that case. Templates are already triggering due to templatesGenerated hook 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant