Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: remove unplugin-vue2-script-setup in favour of native vue 2.7 #384

Merged
merged 1 commit into from
Jul 5, 2022
Merged

fix!: remove unplugin-vue2-script-setup in favour of native vue 2.7 #384

merged 1 commit into from
Jul 5, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #381

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We now no longer need unplugin-vue2-script-setup to enable <script setup> support in Nuxt Bridge.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe requested a review from antfu July 4, 2022 21:34
@danielroe danielroe self-assigned this Jul 4, 2022
@antfu
Copy link
Member

antfu commented Jul 5, 2022

The only downside is that the reactivity transform is not yet available in 2.7, but it should be arrived soon after 3.3 I guess.

@danielroe danielroe merged commit bab9f4b into main Jul 5, 2022
@danielroe danielroe deleted the fix/script-setup branch July 5, 2022 08:02
@danielroe danielroe mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees

@danielroe danielroe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

We don't need unplugin-vue2-script-setup after migrating to Vue 2.7
2 participants
@danielroe @antfu