Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve types and use relative imports for composables #532

Merged
merged 2 commits into from
Sep 13, 2022
Merged

fix: improve types and use relative imports for composables #532

merged 2 commits into from
Sep 13, 2022

Conversation

danielroe
Copy link
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This should improve stability of vite implementation and also improve type support somewhat - I was getting hanging in dev mode in a separate PR owing to circular composable references.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Sep 13, 2022
@danielroe danielroe self-assigned this Sep 13, 2022
@danielroe danielroe merged commit b03ca40 into main Sep 13, 2022
@danielroe danielroe deleted the fix/composables branch September 13, 2022 22:33
@danielroe danielroe mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@danielroe danielroe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danielroe