Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-config): handle app.vue and error.vue in custom srcDir #335

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe self-assigned this Mar 19, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 19, 2024

Deploying nuxt-eslint with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1a5619
Status:⚡️  Build in progress...

View logs

@@ -7,8 +7,11 @@ export default function disables(options: NuxtESLintConfigOptions): FlatConfig[]
const nestedGlobPattern = `**/*.${GLOB_EXTS}`

const fileRoutes = [
relative(dirs.src || '', `app.${GLOB_EXTS}`),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this, but dirs.src is an absolute path, FWIW, and I don't think would do what we want here.

Also, wondering if we should distinguish rootDir from srcDir? Some files, like nuxt.config are always resolved from rootDir but others are resolved from srcDir

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it was a typo, and yeah I agree we should introduce rootDir as well!

@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@antfu antfu merged commit adda0f1 into main Mar 19, 2024
1 of 2 checks passed
@antfu antfu deleted the fix/error-app-srcDir branch March 19, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants