-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-config): handle app.vue
and error.vue
in custom srcDir
#335
Conversation
@@ -7,8 +7,11 @@ export default function disables(options: NuxtESLintConfigOptions): FlatConfig[] | |||
const nestedGlobPattern = `**/*.${GLOB_EXTS}` | |||
|
|||
const fileRoutes = [ | |||
relative(dirs.src || '', `app.${GLOB_EXTS}`), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this, but dirs.src
is an absolute path, FWIW, and I don't think would do what we want here.
Also, wondering if we should distinguish rootDir from srcDir? Some files, like nuxt.config
are always resolved from rootDir
but others are resolved from srcDir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose it was a typo, and yeah I agree we should introduce rootDir as well!
Hi! I'm the autofix.ci troubleshooter bot. It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃 |
context: danielroe/roe.dev@3baf8d4#diff-9601a8f6c734c2001be34a2361f76946d19a39a709b5e8c624a2a5a0aade05f2R20-R25