This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(webpack): output .mjs
to use crossorigin preloads
#6232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielroe
added
bug
Something isn't working
webpack
β p4-important
Priority 4: bugs that violate documented behavior, or significantly impact perf
labels
Jul 29, 2022
β Deploy Preview for nuxt3-docs canceled.
|
Would it be fixed with upcoming vue-bundle-renderer? At some point we have to switch back to |
No, the vue-bundle-renderer PR doesn't change this behaviour when rendering |
pi0
reviewed
Jul 29, 2022
This PR seems good to go until we do this but yes I think it is a viable option to support |
As a top-level option to |
I believe could be in manifest. |
pi0
reviewed
Jul 29, 2022
pi0
approved these changes
Jul 29, 2022
Merged
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.x
bug
Something isn't working
β p4-important
Priority 4: bugs that violate documented behavior, or significantly impact perf
webpack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
We are outputting
.js
files for webpack, which means we also don't add thecrossorigin
attribute when rendering. Because of a typo in our tests we weren't pick up on this.Bug shows up with following warnings (+ double fetches of all webpack JS assets):
π Checklist