Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): add module type to vite node entry #6448

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Aug 8, 2022

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@vite/client is a module. Without this we get Uncaught SyntaxError: import declarations may only appear at top level of a module. Evidently missed from vue-bundle-renderer upgrade.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Aug 8, 2022
@danielroe danielroe requested a review from pi0 August 8, 2022 21:48
@danielroe danielroe self-assigned this Aug 8, 2022
@netlify
Copy link

netlify bot commented Aug 8, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 5c5fb10
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62f184cc5e3c1100086e045f

@pi0 pi0 merged commit ae388e7 into main Aug 9, 2022
@pi0 pi0 deleted the fix/vite-node-entry branch August 9, 2022 07:59
@pi0 pi0 mentioned this pull request Aug 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants