Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

feat(vite): allow disabling entry warmup #6647

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 15, 2022

πŸ”— Linked issue

#6227

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR enables opting out from entry point warmup feature of vite using vite.warmupEntry: false.

This feature ensures that nuxt starts transforming entrypoint code before developer even initiates first request to any page, speeding up time from command to initial render. But as @antfu mentioned, there might be performance overhead in concurrency.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Aug 15, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 882b687
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/62fa683f8175d50008e4eb3f

@pi0 pi0 mentioned this pull request Aug 15, 2022
7 tasks
@pi0 pi0 requested a review from antfu August 15, 2022 15:31
@pi0 pi0 changed the title feat(vite): allow opt-out from warming up entries feat(vite): allow disabling entry warmup Aug 15, 2022
@pi0 pi0 merged commit dae836a into main Aug 15, 2022
@pi0 pi0 deleted the feat/vite-optional-warmup branch August 15, 2022 16:01
@pi0 pi0 mentioned this pull request Aug 26, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants