Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

chore: update examples to ^3.0.0-rc.10 and use global defineNuxtConfig #7515

Merged
merged 4 commits into from
Sep 14, 2022

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 14, 2022

πŸ”— Linked issue

##7497

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Sep 14, 2022

βœ… Deploy Preview for nuxt3-docs ready!

Name Link
πŸ”¨ Latest commit bea83e9
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63220e4d12af6a00087eba4f
😎 Deploy Preview https://deploy-preview-7515--nuxt3-docs.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 changed the title docs: update example to ^3.0.0-rc.10 and use defineNuxtConfig auto import chore: update examples to ^3.0.0-rc.10 and use defineNuxtConfig auto import Sep 14, 2022
@darthf1
Copy link

darthf1 commented Sep 14, 2022

Is it possible to keep the imports somewhere, but with a comment it can be omitted in case of auto import?

It's my understanding now auto imports can be disabled, having the import path visible is still useful. But please correct me if Im wrong.

@pi0
Copy link
Member Author

pi0 commented Sep 14, 2022

It's my understanding now auto imports can be disabled, having the import path visible is still useful. But please correct me if Im wrong.

Feature to disable auto imports is related to runtime bundler. We always have defineNuxtConfig available (check linked PR). But of course you can choose to explicitly import from 'nuxt/config'

@darthf1
Copy link

darthf1 commented Sep 14, 2022

It's my understanding now auto imports can be disabled, having the import path visible is still useful. But please correct me if Im wrong.

Feature to disable auto imports is related to runtime bundler. We always have defineNuxtConfig available (check linked PR). But of course you can choose to explicitly import from 'nuxt/config'

Ah ok! Thanks for the clarification.

Since this PR is to remove all the references to this import from the docs (since it can be auto imported), how is a user (who prefers manual imports) going to know / learn what the import path is? Is it possible to keep one reference somewhere in the docs?

@pi0
Copy link
Member Author

pi0 commented Sep 14, 2022

Added explicit docs. Nice suggestion πŸ‘πŸΌ

@pi0 pi0 changed the title chore: update examples to ^3.0.0-rc.10 and use defineNuxtConfig auto import chore: update examples to ^3.0.0-rc.10 and use global defineNuxtConfig Sep 14, 2022
@pi0 pi0 merged commit 5973df1 into main Sep 14, 2022
@pi0 pi0 deleted the docs/config-import branch September 14, 2022 17:26
@darthf1
Copy link

darthf1 commented Sep 14, 2022

Added explicit docs. Nice suggestion πŸ‘πŸΌ

Awesome. Thank you for making the changes.

@pi0 pi0 mentioned this pull request Sep 15, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants