This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
docs: recommend to not overwrite some keys in tsconfig #7717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
I hit a strange error while upgrading from rc 9 to 11 that
import_meta.hot.accept
was not defined. After a bit of research, I think, I hit evanw/esbuild#2294. At least after removing"target": "ES2018",
from the tsconfig file everything is working smoothly now. So I added a small note to the docs that these keys shouldn't be overwritten.π Checklist