Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

fix(nuxt): use correct cache and add baseURL to payload #7984

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

#7809 (comment)

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Two issues:

  1. we were not caching payloads
  2. we were not respecting baseURL when fetching payloads on client side

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage labels Oct 4, 2022
@danielroe danielroe requested a review from pi0 October 4, 2022 10:16
@danielroe danielroe self-assigned this Oct 4, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 4, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 4, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 66e87fd
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/633c0812970d5300093055be

@danielroe danielroe merged commit 6d90466 into main Oct 9, 2022
@danielroe danielroe deleted the fix/payload-url branch October 9, 2022 14:22
@danielroe danielroe mentioned this pull request Oct 9, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants