Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

perf(nuxt): remove vue-router dependency from minimal app #8188

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This removes vue-router dependency from default app (extracted from #8133). Note that there's still a dependency if using <NuxtLayout> which needs to be resolved separately.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage performance labels Oct 14, 2022
@danielroe danielroe requested a review from pi0 October 14, 2022 08:30
@danielroe danielroe self-assigned this Oct 14, 2022
@codesandbox
Copy link

codesandbox bot commented Oct 14, 2022

CodeSandbox logoCodeSandbox logoΒ  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify
Copy link

netlify bot commented Oct 14, 2022

βœ… Deploy Preview for nuxt3-docs canceled.

Name Link
πŸ”¨ Latest commit 95c5b78
πŸ” Latest deploy log https://app.netlify.com/sites/nuxt3-docs/deploys/63491e1f54bbee00085b0515

@pi0 pi0 changed the title perf: remove vue-router dependency from minimal app perf(nuxt): remove vue-router dependency from minimal app Oct 14, 2022
@pi0 pi0 merged commit 2083ed4 into main Oct 14, 2022
@pi0 pi0 deleted the perf/router branch October 14, 2022 08:36
@pi0 pi0 mentioned this pull request Oct 18, 2022
@danielroe danielroe added the 3.x label Jan 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3.x bug Something isn't working πŸ”¨ p3-minor-bug Priority 3: a bug in an edge case that only affects very specific usage performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants