Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain fall back to larger size on amplify + vercel #1124

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

korve
Copy link
Contributor

@korve korve commented Nov 23, 2023

The documentation states that the image provider will fallback to the >nearest< image width when a image width was not defined in the screens option. This is not the actual behavior. Actually, the next bigger screen width is return. I've tried to reflect this with this change.

The documentation states that the image provider will fallback to the >nearest< image width when a image width was not defined in the screens option. This is not the actual behavior. Actually, the next bigger screen width is return. I've tried to reflect this with this change.
Copy link

nuxt-studio bot commented Nov 23, 2023

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview c371d6e

@pi0 pi0 changed the title Fix incorrect vercel documentation docs(vercel): correct size chooing behavior Nov 23, 2023
@pi0
Copy link
Member

pi0 commented Nov 23, 2023

Thanks! Would you mind to also reflect same change for aws-amplify? 🙏🏼

@korve
Copy link
Contributor Author

korve commented Nov 23, 2023

Thanks! Would you mind to also reflect same change for aws-amplify? 🙏🏼

Yep, done :)

@danielroe danielroe changed the title docs(vercel): correct size chooing behavior docs: explain fall back to larger size on amplify + vercel Nov 23, 2023
@danielroe danielroe merged commit 25329ec into nuxt:main Nov 23, 2023
1 check passed
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants