Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(generator): minify spa fallback #5791

Merged
merged 3 commits into from
May 23, 2019
Merged

Conversation

pimlie
Copy link

@pimlie pimlie commented May 23, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The html for the SPA fallback was not minified after generating the routes, resulting in different files while in SPA mode every generated html file should be the same.

Before:

$ find examples/spa/dist/ -name '*.html' -exec md5sum {} \;
853e7d39c6c79431172d11c71115d487  examples/spa/dist/200.html
4014fb429eb22afeb868705a0dd476db  examples/spa/dist/about/index.html
4014fb429eb22afeb868705a0dd476db  examples/spa/dist/index.html

After:

$ find examples/spa/dist/ -name '*.html' -exec md5sum {} \;
4014fb429eb22afeb868705a0dd476db  examples/spa/dist/200.html
4014fb429eb22afeb868705a0dd476db  examples/spa/dist/about/index.html
4014fb429eb22afeb868705a0dd476db  examples/spa/dist/index.html

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@pimlie pimlie requested review from manniL, pi0 and clarkdo and removed request for manniL and pi0 May 23, 2019 06:23
@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #5791 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5791      +/-   ##
==========================================
+ Coverage   95.64%   95.65%   +<.01%     
==========================================
  Files          82       82              
  Lines        2662     2667       +5     
  Branches      682      682              
==========================================
+ Hits         2546     2551       +5     
  Misses         98       98              
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.61% <0%> (-0.1%) ⬇️
#unit 92.61% <100%> (+0.01%) ⬆️
Impacted Files Coverage Δ
packages/generator/src/generator.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59071e4...20bde24. Read the comment docs.

@codecov-io
Copy link

codecov-io commented May 23, 2019

Codecov Report

Merging #5791 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5791      +/-   ##
==========================================
+ Coverage   95.67%   95.72%   +0.04%     
==========================================
  Files          82       82              
  Lines        2662     2667       +5     
  Branches      682      682              
==========================================
+ Hits         2547     2553       +6     
+ Misses         97       96       -1     
  Partials       18       18
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#fixtures 50.61% <0%> (-0.1%) ⬇️
#unit 92.68% <100%> (+0.05%) ⬆️
Impacted Files Coverage Δ
packages/generator/src/generator.js 100% <100%> (ø) ⬆️
packages/vue-renderer/src/renderer.js 94.3% <0%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a8b9f...b2fcd94. Read the comment docs.

@pi0 pi0 changed the title fix(generator): also minify spa fallback refactor(generator): also minify spa fallback May 23, 2019
@pi0 pi0 changed the title refactor(generator): also minify spa fallback fix(generator): also minify spa fallback May 23, 2019
@pi0 pi0 changed the title fix(generator): also minify spa fallback fix(generator): minify spa fallback May 23, 2019
@pi0 pi0 requested a review from a team May 23, 2019 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants