Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): flatRoutes regex for nested routes with trailing slash enabled #6791

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

cain
Copy link

@cain cain commented Dec 16, 2019

Nested routes with trailingSlash: true nuxt config is getting double forward slash paths.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #6783

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • [] All new and existing tests are passing.

@cain
Copy link
Author

cain commented Dec 16, 2019

I need some help working out why I'm getting this result when all the tests are passing correctly. Please see #6783

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #6791 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6791   +/-   ##
=======================================
  Coverage   64.82%   64.82%           
=======================================
  Files          78       78           
  Lines        2718     2718           
  Branches      706      706           
=======================================
  Hits         1762     1762           
  Misses        729      729           
  Partials      227      227
Flag Coverage Δ
#e2e 100% <ø> (ø) ⬆️
#unit 64.82% <100%> (ø) ⬆️
Impacted Files Coverage Δ
packages/utils/src/route.js 96.82% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112d836...d028a19. Read the comment docs.

@atinux atinux self-requested a review December 16, 2019 11:16
@pi0 pi0 changed the title fix: utils route flatRoutes regex fix for nested routes with trailing slash enabled fix(utils): flatRoutes regex for nested routes with trailing slash enabled Dec 16, 2019
@pi0 pi0 merged commit ae769ce into nuxt:dev Dec 16, 2019
@cain
Copy link
Author

cain commented Dec 16, 2019

@pi0 @atinux thanks for quick approval :)

@pi0 pi0 mentioned this pull request Dec 17, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested routes with trailingSlash: true incorrect path structure (double forward slash)
5 participants