Skip to content

Commit

Permalink
Enable cancellable speech by default (PR #11266)
Browse files Browse the repository at this point in the history
First introduced with "Cancellable speech #10885"
Several issues fixed with "Fix several issues in speech manager #11245"
  • Loading branch information
feerrenrut authored Mar 17, 2021
1 parent 4b74c7b commit 5fbe05d
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion source/gui/settingsDialogs.py
Original file line number Diff line number Diff line change
Expand Up @@ -2648,7 +2648,7 @@ def __init__(self, parent):
expiredFocusSpeechChoices = [
# Translators: Label for the 'Cancel speech for expired &focus events' combobox
# in the Advanced settings panel.
_("Default (No)"),
_("Default (Yes)"),
# Translators: Label for the 'Cancel speech for expired &focus events' combobox
# in the Advanced settings panel.
_("Yes"),
Expand Down
4 changes: 2 additions & 2 deletions source/speech/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@


def _shouldCancelExpiredFocusEvents():
# 0: default (no), 1: yes, 2: no
return config.conf["featureFlag"]["cancelExpiredFocusSpeech"] == 1
# 0: default (yes), 1: yes, 2: no
return config.conf["featureFlag"]["cancelExpiredFocusSpeech"] != 2


def _shouldDoSpeechManagerLogging():
Expand Down
3 changes: 3 additions & 0 deletions user_docs/en/changes.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ What's New in NVDA
- Added more mathematical symbols to the symbols dictionary. (#11467)
- The user guide, changes file, and key commands listing now have a refreshed appearance. (#12027)
- "Unsupported" now reported when attempting to toggle screen layout in applications that do not support it, such as Microsoft Word. (#7297)
- 'Attempt to cancel speech for expired focus events' option in the advanced settings panel now enabled by default.
- This behaviour can be disabled by default with by setting this option to "No".
- Web applications (E.G. Gmail) no longer speak outdated information when moving focus rapidly. (#10885)


== Bug Fixes ==
Expand Down

0 comments on commit 5fbe05d

Please sign in to comment.