Skip to content

Commit

Permalink
Braille Viewer: Add a close button on the title bar for use with poin…
Browse files Browse the repository at this point in the history
…ting devices (#12328)

The Braille Viewer currently presents no close control on its GUI.
It can only be closed with alt+F4 or by means of the dedicated NVDA Tools menu entry.

Description of how this pull request fixes the issue:
Add a standard close button on the title bar of the Braille Viewer dialog.
  • Loading branch information
JulienCochuyt authored Apr 29, 2021
1 parent f84a7d9 commit e2d2696
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
4 changes: 2 additions & 2 deletions source/brailleViewer/brailleViewerGui.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2014-2019 NV Access Limited
# Copyright (C) 2014-2021 NV Access Limited, Accessolutions, Julien Cochuyt
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
import enum
Expand Down Expand Up @@ -280,7 +280,7 @@ def __init__(self, numCells, onDestroyed):
gui.mainFrame,
title=self._title,
pos=dialogPos,
style=wx.CAPTION | wx.STAY_ON_TOP
style=wx.CAPTION | wx.CLOSE_BOX | wx.STAY_ON_TOP
)
self.Bind(wx.EVT_CLOSE, self._onClose)
self.Bind(wx.EVT_WINDOW_DESTROY, self._onDestroy)
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ What's New in NVDA
- Support for Adobe Flash content has been removed from NVDA due to the use of Flash being actively discouraged by Adobe. (#11131)
- NVDA will exit even with windows still open, the exit process now closes all NVDA windows and dialogs (#1740)
- The Speech Viewer can now be closed with `alt+F4` and has a standard close button for easier interaction with users of pointing devices. (#12330)
- The Braille Viewer now has a standard close button for easier interaction with users of pointing devices. (#12328)


== Bug Fixes ==
Expand Down

0 comments on commit e2d2696

Please sign in to comment.