-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nvda does not announce the accentuation of the letter if the check box is Say capitalization before capitalization #11948
Comments
Hello @fernando-jose-silva I have proposed a pull-request (#11977) that should fix this issue. Could you confirm that your issue disappear with this test build |
Thank you very much, the test compilation works correctly. |
Fixes #11948 # Summary of the issue: As described in #11948, some letter with diacritic is not spelt correctly with some synth if "Say cap before capitale" is checked, e. g. 'À' is spelt 'cap A' instead of 'cap A grave'. Looking at getSpellingSpeech function in speech\__init__.py, it appears that this is due to the fact that the string 'cap À' is passed to the synth in the speech sequence in such a case. But the synth is only asked to use character mode for the strings whose length is 1. This is wrong in this case, because 'cap' should be spoken with character mode off, but 'À' should be spoken with character mode on. # Description of how this pull request fixes the issue: In getSpellingSpeech, in the string sequence, I have separated the 'cap' message string from the character to be spelt. If the character to be spelt is of length 1, i.e. not replaced by symbol description or modified pronunciation, character mode is activated. If a string in the speech sequence has a length > 1, because it is a capitalization message or because it corresponds to a character description or symbol replacement, character mode is disabled. Note that the 'cap' message can be of two types: - with 'cap' indication before as in English: 'cap %s' - with 'cap' indication after as in French: '%s majuscule' Co-authored-by: Reef Turner <[email protected]>
Helo! |
Hi @ruifontes |
Hello! In NVDA 2021.1 Beta1 the log shows: So, the major difference is: Still necessary to create an issue? |
Yes open a new issue with all the information required by the template and also in my previous message. |
@ruifontes could you indicate if you are still experimenting the issue you were describing?
|
Steps to reproduce:
Open a text editor
In the nvda speech settings select the checkbox
Say capitalization before capitalization
return to the text editor
turn on capslook
type letters with accents
examples:
Á
À
Ã
É
Ê
Í
Ó
Ô
Ú
read the accented letters typed with the left and right arrows
Actual behavior:
nvda informs
the character name is spoken
character accent is not spoken
is spoken capitalized
Expected behavior:
nvda informs:
speak the name of the character
speaks the accentuation of the character
speaks capital letter
System configuration
NVDA installed/portable/running from source:
instaled
NVDA version:
nvda.exe, NVDA alpha-21524,7b92e442
Windows version:
windows 10 19042.662
Name and version of other software in use when reproducing the issue:
any text editor
Other information about your system:
if the checkbox
Say capitalization before capitalization
is unchecked and the user chooses another way to receive the capitalization status of the letters, everything works fine.
In this case I want the nvda to announce the capitalization of the letters, and the accentuation of the letters as well.
tested with several synthesizers and the problem remains
Other questions
Does the issue still occur after restarting your computer?
yes
Have you tried any other versions of NVDA? If so, please report their behaviors.
yes
If addons are disabled, is your problem still occuring?
yes
Did you try to run the COM registry fixing tool in NVDA menu / tools?
no
The text was updated successfully, but these errors were encountered: