UI Automation in Windows Console: report space for blank console characters #10562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonarddeR
reviewed
Dec 2, 2019
Co-Authored-By: Leonard de Ruijter <[email protected]>
michaelDCurran
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #10036.
Summary of the issue:
Inline spaces are announced as "blank" in Windows Console, due to the underlying implementation.
Description of how this pull request fixes the issue:
Report "space" for empty console text ranges, as suggested by @michaelDCurran in the issue.
Testing performed:
Tested that inline spaces are reported as "space" when deleting text.
Known issues with pull request:
None.
Change log entry:
None.